Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #602 (closed defect: fixed)

Opened 2 years ago

Last modified 19 months ago

pincode is shown in log.

Reported by: airzimmy Owned by: mickey
Priority: major Milestone: cornucopia-0.10
Component: cornucopia/fsogsm Version:
Keywords: Cc:

Description

Runnng SHR-T 2011.1 rc3 I have spotted while reading the logs the pincode is shown in the log file. Could this be masked?

fsogsmd.log:2011-03-06T19:05:33.642858Z [INFO] libfsotransport <0710:2>: SRC: "+CPIN="PINCODE"" -> [ "OK" ] fsogsmd.log:2011-03-06T19:17:03.955415Z [INFO] libfsotransport <0710:2>: SRC: "+CPIN="PINCODE"" -> [ "OK" ] fsogsmd.log:2011-03-06T19:23:29.963702Z [INFO] libfsotransport <0710:2>: SRC: "+CPIN="PINCODE"" -> [ "OK" ]

PINCODE masks the pincode

Change History

comment:1 Changed 19 months ago by morphis

  • Milestone set to fso2-milestone1

comment:2 Changed 19 months ago by morphis

Masking the pin doesn't help here. The problem is the logging level used for this line. It should be never logged in INFO log level but in DEBUG log level. As DEBUG is never set in production the PIN will never appear on an end user device in the log files.

comment:3 Changed 19 months ago by morphis

  • Status changed from new to closed
  • Resolution set to fixed

It's fixed with commit 37830a46530f3a8954248d2a46e07a7c9734ee4c

Note: See TracTickets for help on using tickets.