fsogsmd: bug in the AT parser exposed by CMGS timeout too small

[PaulFertser]

2000-01-03T19:14:34.227196Z [DEBUG] libfsotransport <0710:2>: Wrote '+CMMS=1'. Waiting (5s) for answer...
2000-01-03T19:14:34.241412Z [INFO]  libfsotransport <0710:2>: SRC: "+CMMS=1" -> [ "OK" ]
2000-01-03T19:14:34.244559Z [DEBUG] libfsotransport <0710:2>: Wrote 'AT+CMGS=153^M'. Waiting (5s) for answer...
2000-01-03T19:14:34.277258Z [INFO]  libfsotransport <0710:2>: SRC: "AT+CMGS=153^M" -> [ "> " ]
2000-01-03T19:14:34.302609Z [DEBUG] libfsotransport <0710:2>: Wrote '0051000B919761315387F80008A78B06080400080501042F0020044104
3504390447043004410020043804490443002C0020043D043E0020043D04350020043F043E0445043E04360435002C002004470442043E00200433043404350
02D0442043E0020043504410442044C002C002004420430043A002004470442043E0020043D043500200441043E0432043504420443044E002E00200422^Z'.
 Waiting (5s) for answer...
2000-01-03T19:14:35.446305Z [INFO]  libfsotransport <0710:3>: URC: [ "%CPRI: 1,2" ]
2000-01-03T19:14:35.447241Z [DEBUG] TiCalypsoUnsolicitedResponseHandler : Dispatching AT unsolicited '%CPRI', '1,2'
2000-01-03T19:14:35.448217Z [DEBUG] TiCalypsoModem <4C>: Did receive a valid response for TiCalypsoPercentCPRI
2000-01-03T19:14:40.005124Z [WARN]  libfsotransport <0710:2>: Timeout while waiting for an answer to '0051000B919761315387F8000
8A78B06080400080501042F00200441043504390447043004410020043804490443002C0020043D043E0020043D04350020043F043E0445043E04360435002C
002004470442043E0020043304340435002D0442043E0020043504410442044C002C002004420430043A002004470442043E0020043D043500200441043E043
2043504420443044E002E00200422^Z'
2000-01-03T19:14:40.007215Z [DEBUG] libfsotransport <0710:2>: Retrying '0051000B919761315387F80008A78B06080400080501042F0020044
1043504390447043004410020043804490443002C0020043D043E0020043D04350020043F043E0445043E04360435002C002004470442043E00200433043404
35002D0442043E0020043504410442044C002C002004420430043A002004470442043E0020043D043500200441043E0432043504420443044E002E00200422
^Z', retry counter = 2
2000-01-03T19:14:40.286281Z [INFO]  libfsotransport <0710:2>: SRC: "0051000B919761315387F80008A78B06080400080501042F00200441043
504390447043004410020043804490443002C0020043D043E0020043D04350020043F043E0445043E04360435002C002004470442043E002004330434043500
2D0442043E0020043504410442044C002C002004420430043A002004470442043E0020043D043500200441043E0432043504420443044E002E00200422^Z" -
> [ "OK" ]
2000-01-03T19:14:40.287271Z [WARN]  TiCalypsoModem <4C>: Unexpected length 1 for FsoGsmPlusCMGS

[PaulFertser]

Sorry for being somewhat obvious but please notice several problems highlighted by this log:

1. Retrying to send a PDU to the modem after "> " is received from it is a rather questionable measure and i'd say most probably should be avoided, rather the whole CMGS command should be cancelled and retried.

2. The last line of the log is too surprising and imho should really be tracked down to the real cause as chances are that it's an indication of an important pitfall in the parser.

[morphis]

This seems to have it's origin in the processAtPduCommandAsync method of the modem class. Further investigation is needed.

[morphis]

I need to talk here about the implementation mickey did before chaging anything to fix this. I don't thing a possible fix will be part of 0.11.