Commas in Names confuse ogsmd

[daniel]

When the name of my contact includes a comma - like this +CPBR: 2,"**********",145,"Moeckel,Marek"

then RetrievePhonebook? fails because the split picks up that additional comma

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/channel.py", line 218, in _readyToRead
    self.readyToRead( data )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/channel.py", line 354, in readyToRead
    self.parser.feed( data, not self.q.empty() )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/parser.py", line 127, in feed
    nextstate = self.state( b, haveCommand )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/parser.py", line 172, in state_inline_r
    return self.solicitedLineCompleted()
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/parser.py", line 201, in solicitedLineCompleted
    self.response( self.lines )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/channel.py", line 443, in _handleResponseToRequest
    self.handleResponseToRequest( request, response )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/channel.py", line 382, in handleResponseToRequest
    ok_cb( reqstring.strip(), response )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/gsm/decor.py", line 45, in logIt
    result = fn( *args, **kwargs )
  File "/usr/lib/python2.5/site-packages/framework/subsystems/ogsmd/modems/abstract/mediator.py", line 555, in responseFromChannel
    index, number, ntype, name = self._rightHandSide( entry ).split( ',' )
ValueError: too many values to unpack

[daniel]

Okay, solved the problem with a split( ",", 3 )

This is a safe solution *only* if we can expect the number field to not contain a comma, ever. I believe that is the case, but we should investigate that further.

[daniel]

Fixed in [c11b95784df0fbf76264c039e57baeaa1b393e00] which also fixes the same problem in RetrieveEntry?.