Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #50 (new defect)

Opened 5 years ago

Last modified 4 years ago

Improve NMEA parser

Reported by: daniel Owned by: daniel
Priority: minor Milestone:
Component: cornucopia/fsotdld Version:
Keywords: Cc:

Description

The current NMEA parser is buggy and incomplete. It expects values where some GPS devices don't report any and doesn't tie in to the gypsy dbus interface.

Attachments

nmea.py​ (9.5 KB) - added by rwhitby 5 years ago.

Change History

comment:1 Changed 5 years ago by daniel

  • Milestone set to milestone4

Changed 5 years ago by rwhitby

comment:2 Changed 5 years ago by rwhitby

Updated nmea.py attached, tested on GTA01 with TangoGPS.

comment:3 Changed 5 years ago by daniel

Hey, thanks for the patch! I had a brief look and I'd say just commit it. There is so much improved (i.e. sending the DBus signals) that it will work much better anyway.

Just one whitespace nitpick: Please set your editor to indent 4 spaces and not use any tabs. Oh, and you don't need to import dbus any more.

Regards, Daniel

comment:4 Changed 5 years ago by rwhitby

Committed in ed2d0266b41cd64b1187c64c3750c2fa53ffbb44 - will fix other comments in a second round.

comment:5 Changed 5 years ago by daniel

  • Milestone changed from milestone4 to milestone5

comment:6 Changed 4 years ago by daniel

  • Milestone milestone5 deleted

This is more a long term goal (aka NMEA parsing is good enough...)

comment:7 Changed 4 years ago by mickey

  • Component changed from framework/ogpsd to cornucopia/fsogps

Moving this to fso2.

Note: See TracTickets for help on using tickets.