Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #433 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Trying to send two SMS at once results in a race condition while enqueueing multiline commands

Reported by: daniel Owned by: mickey
Priority: blocker Milestone: milestone5.5
Component: framework/ogsmd Version:
Keywords: Cc:

Description

See that the AT+CMGS=76 is enqueued and sent *before* the actual PDU is even enqueued: 

2009.05.15 17:42:42.177 oeventsd.fso_triggers INFO     Receive IdleState, status = busy
2009.05.15 17:42:42.192 oeventsd             INFO     CommandAction xset -display localhost:0 s reset
2009.05.15 17:42:42.503 oeventsd.fso_triggers INFO     Receive IdleState, status = busy
2009.05.15 17:42:48.676 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: Autogenerated prefixes for command 'AT+CMGS=77\r': set(['+CMGS'])
2009.05.15 17:42:48.689 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: _readyToSend: watch timeout = None
2009.05.15 17:42:48.697 ogsmd                DEBUG    (<MiscChannel via /dev/pts/0>: last communication with modem was 10 seconds ago. Sending EOF to wakeup)
2009.05.15 17:42:48.921 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: sending 11 bytes: 'AT+CMGS=77\r'
2009.05.15 17:42:49.19 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: Autogenerated prefixes for command 'AT+CMGS=76\r': set(['+CMGS'])
2009.05.15 17:42:49.50 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: _readyToRead: watch timeout = 1905
2009.05.15 17:42:49.59 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: got 4 bytes: '\r\n> '
2009.05.15 17:42:49.85 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: COMPLETED 'AT+CMGS=77' => []
2009.05.15 17:42:49.106 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: Autogenerated prefixes for command '00[...]\x1a': set([])
2009.05.15 17:42:49.119 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: _readyToSend: watch timeout = None
2009.05.15 17:42:49.129 ogsmd.channel        DEBUG    <MiscChannel via /dev/pts/0>: sending 11 bytes: 'AT+CMGS=76\r'
2009.05.15 17:42:52.5 odeviced.idlenotifier INFO     odeviced.idlenotifier state change to idle

Change History

comment:1 Changed 4 years ago by daniel

This was fixed already, right?

comment:2 Changed 4 years ago by mickey

Yes, that should be ok.

comment:3 Changed 4 years ago by daniel

  • Status changed from new to in_testing

Please retest

comment:4 Changed 4 years ago by daniel

  • Status changed from in_testing to closed
  • Resolution set to fixed

Just sent three SMS via shr so this is fixed now.

Note: See TracTickets for help on using tickets.