Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #388 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Check parameter range for +CLVL

Reported by: mickey Owned by: mickey
Priority: major Milestone: cornucopia-0.11
Component: framework/ogsmd Version:
Keywords: org.freesmartphone.GSM.Device.[Get|Set]LoudspeakerVolume Cc:

Description

All modems are different, so we need to check the range of +CLVL before mapping.

Change History

comment:1 Changed 4 years ago by daniel

  • Status changed from new to closed
  • Resolution set to fixed

Looks like this got fixed in 

commit 1b57e0a6bab423f4f74c0107b4bb9bd83733ee42
Author: Michael 'Mickey' Lauer <mickey@vanille-media.de>
Date:   Fri Mar 20 19:46:33 2009 +0100

    ogsmd: Do not assume a range of 0-255 for +CLVL, rather
    query the modem first. If the respective query is not supported,
    _then_ assume 0-255. [QUALCOMM MSM] uses a range of 0-5.
Note: See TracTickets for help on using tickets.