Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #374 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

SetCurrentTime type problem in odeviced

Reported by: jeremy Owned by: daniel
Priority: major Milestone: milestone5.5
Component: framework/odeviced Version: milestone5
Keywords: Cc: mickey, daniel

Description

SetCurrentTime? interface has a problem to be called.

It says an error about it needs the argument to be float type though the dbus interface defines it a string type.

Attachments

SetCurrentTime.patch​ (617 bytes) - added by jeremy 4 years ago.
a simple patch here.

Change History

Changed 4 years ago by jeremy

a simple patch here.

comment:1 Changed 4 years ago by daniel

  • Owner changed from mickey to daniel
  • Status changed from new to assigned

Okay, why is this even a string? This should be a float (or an int) IMHO.

​http://git.freesmartphone.org/?p=specs.git;a=blob_plain;f=html/org.freesmartphone.Device.RealtimeClock.html;hb=HEAD lists the arguments as int and I think that is okay.

One thing that the spec seems to get wrong ist SetWakeupTime? ( b ), though. Clearly that should be i as well.

comment:2 Changed 4 years ago by daniel

  • Status changed from assigned to closed
  • Resolution set to fixed

Should be fixed in commit [f7e40ab0c79528e065c75ca938645bb7ba5a7294] 

>>> devrtc.GetWakeupTime()
0
>>> devrtc.SetWakeupTime(1239267246)
>>> devrtc.GetWakeupTime()
1239267246
>>> devrtc.SetWakeupTime(0)
>>> devrtc.GetWakeupTime()
0

WARNING, the RTC interface takes int as parameter now, not string.

Note: See TracTickets for help on using tickets.