Space in ringtone filename confuses odeviced

[zub]

While playing with various ringtones I discovered a space in the filename confuses odeviced:

2008.12.14 03:37:27 mppl.asyncworker DEBUG    _processElement()
2008.12.14 03:37:27 mppl.asyncworker DEBUG    got an element from the queue
2008.12.14 03:37:27 odeviced.audio DEBUG    getting task from queue...
2008.12.14 03:37:27 odeviced.audio DEBUG    got task: play (dbus.String(u'/media/card/sounds/Cross It.sid'), dbus.Int32(0), dbus.Int32(60))
2008.12.14 03:37:28 odeviced.audio ERROR    could not instanciate pipeline: No element named "It" - omitting link
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/framework/subsystems/odeviced/audio.py", line 242, in task_play
    pipeline = gst.parse_launch( "filesrc location=%s ! %s ! alsasink" % ( file, decoder ) ) GError: No element named "It" - omitting link
2008.12.14 03:37:28 oeventsd ERROR    signal PlaySound emited an error org.free smartphone.Device.Audio.PlayerError: Could not instanciate pipeline due to an internal error.
2008.12.14 03:37:28 mppl.asyncworker DEBUG    _processElement()
2008.12.14 03:37:28 mppl.asyncworker DEBUG    no more elements: stopping idle task.

(The path and file name were correct, changing the space into _ in file name and in profile config makes it work.)

[zub]

quote the ringtone filename in odeviced/audio.py

[zub]

Trivial patch to enclose the filename in "..." still doesn't seem to solve the issue, instead it brings a weird avalanche of issues:

2008.12.14 04:44:02 odeviced.audio DEBUG    got task: play (dbus.String(u'/media/card/sounds/Cross It.sid'), dbus.Int32(0), dbus.Int32(60))
2008.12.14 04:44:02 odeviced.audio DEBUG    launching pipeline: "filesrc location="/media/card/sounds/Cross It.sid" ! siddec ! alsasink"
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: STATE NOW: (<enum GST_STATE_NULL of type GstState>) -> <enum GST_STATE_READY of type GstState> -> (<enum GST_STATE_VOID_PENDING of type GstState>)
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: STATE NOW: (<enum GST_STATE_NULL of type GstState>) -> <enum GST_STATE_READY of type GstState> -> (<enum GST_STATE_VOID_PENDING of type GstState>)
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: STATE NOW: (<enum GST_STATE_NULL of type GstState>) -> <enum GST_STATE_READY of type GstState> -> (<enum GST_STATE_VOID_PENDING of type GstState>)
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: STATE NOW: (<enum GST_STATE_NULL of type GstState>) -> <enum GST_STATE_READY of type GstState> -> (<enum GST_STATE_PLAYING of type GstState>)
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: STATE NOW: (<enum GST_STATE_READY of type GstState>) -> <enum GST_STATE_PAUSED of type GstState> -> (<enum GST_STATE_VOID_PENDING of type GstState>)
2008.12.14 04:44:03 odeviced.audio DEBUG    GST message received while file status = unknown
2008.12.14 04:44:03 odeviced.audio DEBUG    G: ERROR: Resource not found. gstfilesrc.c(971): gst_file_src_start (): /pipeline0/filesrc0:
No such file "/media/card/sounds/Cros"
2008.12.14 04:44:03 oeventsd ERROR    signal PlaySound emited an error org.freesmartphone.Device.Audio.PlayerError: Resource not found.
2008.12.14 04:44:04 mppl.asyncworker DEBUG    _processElement()
2008.12.14 04:44:04 mppl.asyncworker DEBUG    no more elements: stopping idle task.

Trying essentially the same code on PC, with the same .sid file, works. (?)

[mickey]

fixed in [08e955a3cad3dd68efae4089f7a007054be8a2f1] -- thanks!