Ticket #295 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

ogsmd: Use kobject notification instead of polling

Reported by: lindi Owned by: mickey
Priority: minor Milestone:
Component: framework/ogsmd Version:
Keywords: Cc:

Description

I have turned on ogsmd debugging so that I can see all AT commands and replies. However, this makes fso-frameworkd 0.8.4.3-20081130-1 also log the following every two seconds: 

2008.12.12 12:48:02 ogsmd.pdp DEBUG    route status. old=usb0, last=usb0, current=usb0
2008.12.12 12:48:04 ogsmd.pdp DEBUG    route status. old=usb0, last=usb0, current=usb0
2008.12.12 12:48:06 ogsmd.pdp DEBUG    route status. old=usb0, last=usb0, current=usb0
2008.12.12 12:48:08 ogsmd.pdp DEBUG    route status. old=usb0, last=usb0, current=usb0

Change History

comment:1 Changed 3 years ago by mickey

  • Status changed from new to assigned
  • Summary changed from ogsmd logging is too verbose: ogsmd.pdp DEBUG route status. old=usb0, last=usb0, current=usb0 to ogsmd: Use kobject notification instead of polling
  • Type changed from defect to enhancement
  • Milestone set to milestone5

Well, DEBUG is supposed to be verbose :)

The actual problem is that I'm polling for the route status instead of using kobject notification -- then we can safely remove that debug message.

Changing the description.

comment:2 Changed 3 years ago by stefan

  • Milestone milestone5 deleted

We need a kobject multiplexer for this as we also use this somewhere else. Will be done, but its an optimization so we remove milestone tag.

comment:3 Changed 3 years ago by mickey

  • Status changed from assigned to closed
  • Resolution set to fixed

This has been implemented now.

Note: See TracTickets for help on using tickets.