Opened 6 years ago

Closed 6 years ago

#294 closed defect (fixed)

Please fix fso-gpsd's init script

Reported by: Sascha Owned by: mickey
Priority: major Milestone:
Component: packaging/distribution Version: milestone4
Keywords: Cc:

Description

fso-gpsd listens on all available interfaces by default (like gpsd).

Since fso-gpsd is installed by default in current images,
I suggest to add "-S localhost:gpsd" to the init script:

fso-gpsd -S localhost:gpsd

This requires version 0.8.

Change History (5)

comment:1 Changed 6 years ago by Sascha

  • Summary changed from fso-gpsd should listen on localhost:gpsd to Please fix fso-gpsd's init script
  • Type changed from enhancement to defect

Another issue: fso-gpsd forks itself to the background, so start-stop-daemon's --make-pidfile doesn't work. Instead fso-gpsd can write the pid file:

fso-gpsd -S localhost:gpsd -P /var/run/fso-gpsd.pid

comment:2 Changed 6 years ago by stefan

  • Resolution set to fixed
  • Status changed from new to closed

Commited in rev 448c0f81a2c8d902c0582cd843cc14d2e40da98f OE.dev

Thanks for letting us know.

comment:3 Changed 6 years ago by Sascha

I've not tried it yet, but I don't think that your usage of start-stop-daemon will work.

According to the start-top-daemon manual page sth. like this should work (untested):

start-stop-daemon --start --pidfile /var/run/fso-gpsd.pid -exec /usr/sbin/fso-gpsd -- -S localhost:gpsd -P /var/run/fso-gpsd.pid

comment:4 Changed 6 years ago by Sascha

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 Changed 6 years ago by stefan

  • Resolution set to fixed
  • Status changed from reopened to closed

The hopefully final string should look like this (exec needs two dashes as long option)
start-stop-daemon --start --pidfile /var/run/${NAME}.pid --exec /usr/sbin/fso-gpsd -- -S localhost:gpsd -P /var/run/${NAME}.pid

commited, sorry for the delay.

428c26aebacd286ef5bfdcba157211978ff938a2

Note: See TracTickets for help on using tickets.