Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #294 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Please fix fso-gpsd's init script

Reported by: Sascha Owned by: mickey
Priority: major Milestone:
Component: packaging/distribution Version: milestone4
Keywords: Cc:

Description

fso-gpsd listens on all available interfaces by default (like gpsd).

Since fso-gpsd is installed by default in current images, I suggest to add "-S localhost:gpsd" to the init script:

fso-gpsd -S localhost:gpsd

This requires version 0.8.

Change History

comment:1 Changed 5 years ago by Sascha

  • Type changed from enhancement to defect
  • Summary changed from fso-gpsd should listen on localhost:gpsd to Please fix fso-gpsd's init script

Another issue: fso-gpsd forks itself to the background, so start-stop-daemon's --make-pidfile doesn't work. Instead fso-gpsd can write the pid file:

fso-gpsd -S localhost:gpsd -P /var/run/fso-gpsd.pid

comment:2 Changed 5 years ago by stefan

  • Status changed from new to closed
  • Resolution set to fixed

Commited in rev 448c0f81a2c8d902c0582cd843cc14d2e40da98f OE.dev

Thanks for letting us know.

comment:3 Changed 5 years ago by Sascha

I've not tried it yet, but I don't think that your usage of start-stop-daemon will work.

According to the start-top-daemon manual page sth. like this should work (untested):

start-stop-daemon --start --pidfile /var/run/fso-gpsd.pid -exec /usr/sbin/fso-gpsd -- -S localhost:gpsd -P /var/run/fso-gpsd.pid

comment:4 Changed 5 years ago by Sascha

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:5 Changed 5 years ago by stefan

  • Status changed from reopened to closed
  • Resolution set to fixed

The hopefully final string should look like this (exec needs two dashes as long option) start-stop-daemon --start --pidfile /var/run/${NAME}.pid --exec /usr/sbin/fso-gpsd -- -S localhost:gpsd -P /var/run/${NAME}.pid

commited, sorry for the delay.

428c26aebacd286ef5bfdcba157211978ff938a2

Note: See TracTickets for help on using tickets.