Ticket #139 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[Patch] Zhone dialer button incorrectly grayed out

Reported by: hedora Owned by: mickey
Priority: major Milestone:
Component: zhone/general Version:
Keywords: Cc:

Description

Please apply the attached patch to zhone.

Symptom:

After boot in FSO MS3 (20080909) and under debian + fso, this is what zhone says:

2008-09-15 -> "turning on antenna" -> "registering to network" -> "Failed to register to network" -> 2008-09-15.

Then 'tmobile' appears in the illume bar, but the phone button is still disabled. The contact book icon is in color and I have no trouble calling people in my address book. It happens every time I boot. Shutting down zhone and restarting it fixes the problem.

This problem is due to the DBUS Register() command timing out. Once that timeout occurs, cbRegistrationReply is never called, so the phone button can never be enabled.

Bugfix:

I've attached a patch that moves the network registration callback code into a signal handler that listens for changes in network status. In addition to handling slow registration correctly, this code should gray out the dialer button when the GSM connection goes away.

Example of "no network" Status signal (this is fired right after Register() returns with an error):

2008-09-15 22:59:51,513 INFO network status changed: dbus.Dictionary({dbus.String(u'mode'): dbus.String(u'automatic', variant_level=1), dbus.String(u'registration'): dbu s.String(u'busy', variant_level=1)}, signature=dbus.Signature('sv'))

Example of "registered" Status signal:

2008-09-15 23:00:12,539 INFO network status changed: dbus.Dictionary({dbus.String(u'strength'): dbus.Int32(64, variant_level=1), dbus.String(u'cid'): dbus.String(u'DEAD', variant_level=1), dbus.String(u'provider'): dbus.String(u'T-Mobile ', variant_level=1), dbus.String(u'lac'): dbus.String(u'BEEF', variant_level=1), dbus.String(u'mode'): dbus.String(u'automatic', variant_level=1), dbus.String(u'registration'): dbus.String(u'home', variant_level=1)}, signature=dbus.Signature('sv'))

Attachments

zhone-registration.patch Download (2.2 KB) - added by hedora 3 years ago.
Move GSM registration handling from Register() callback to network Status signal handler

Change History

Changed 3 years ago by hedora

Move GSM registration handling from Register() callback to network Status signal handler

comment:1 Changed 3 years ago by mickey

  • Status changed from new to closed
  • Resolution set to fixed

Commited -- thanks!

Note: See TracTickets for help on using tickets.