RetrieveMessagebook method returns a SIM.NotFound error if the message list is empty

[charlie]

In fact the actual error returned by the modem is CMS 321, that is : invalid message index.

This bug is the same than this one :  http://docs.openmoko.org/trac/ticket/1757

citing 'balrog' : "Error 321 is "Invalid Memory Index", which means that there are no messages in the inbox. (Fully 3GPP compliant modems would just list zero messages and print OK but the TI Calypso is known to be special and give INVALID_MEMORY_INDEX"

[Sven Petai <hadara@…>]

Current exception throwing behavior also breaks the zhone SMS component when you have no messages on the SIM yet, since component initialization calls RetrieveMessagebook?(”all”) and initialization of the component is not done if exception is returned. This might also be the cause of the bug #144

Attached is the patch to the frameworkd that makes it return empty list instead of the exception when calypso returns error 321

[daniel]

Just returning an empty list makes more sense than returning SIM.NotFound? I believe. SIM.NotFound? sounds like the category doesn't even exist.

The patch looks fine. Mickey, what's your opinion on this?

[mickey]

Agreed, although I'd rather check for this in the generic handling method as I could imagine it's not just a Calypso specific thing. Did that in [df84c48ba7b142f2cdf5107837ce30bfe187a0b0], thanks all!