Warning: Can't synchronize with repository "(default)" (No changeset 96d22ec3fa3ef6de3ea8dc0d7d398adc9aa071cf in the repository). Look in the Trac log for more information.

Ticket #129 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

ogpsd attempts to send GPS aiding data even when it is not present

Reported by: fso@… Owned by: daniel
Priority: major Milestone:
Component: framework/ogpsd Version:
Keywords: HasPatch Cc:

Description

On a cold boot (no aiding.dat file available) the dictionaries that would have been unpickled from it are set to empty dictionaries instead. The code then attempts to lookup entries within these dictionaries to feed aiding data to the chip, but the dictionaries are empty resulting in a key error.

I have attached a patch which fixes this by only attempting to send each component of the aiding data is a non-empty dictionary is present.

Attachments

aiding-data-validity.diff​ (1.8 KB) - added by fso@… 5 years ago.
only sending aiding data when valid dictionaries are present

Change History

Changed 5 years ago by fso@…

only sending aiding data when valid dictionaries are present

comment:1 Changed 5 years ago by daniel

  • Status changed from new to closed
  • Resolution set to fixed

Thanks, committed in [bea759fbbc6fc1b2a7c2ba5a33dacfa0e1a92f2b]. I also committed a patch that doesn't even ask the GPS to send AID-DATA if the aiding file doesn't exist. But your patch makes sense anyway. Thanks!

Note: See TracTickets for help on using tickets.